Declare connection plugin variables and use them with get_option

andreasscherbaum / ansible-lxc-ssh

Ansible connection plugin using ssh + lxc-attach

45 stars 22 forks source link

Declare connection plugin variables and use them with get_option #31

Closed dmp1ce closed 3 years ago

dmp1ce commented 3 years ago

Declare all SSH variables from ssh.py
Use self.get_option where required
Update the _build_command from latest ssh.py
Declare lxc_host variable for declaring the container name to use

Fixes #30

The lxc_host needed to be created because the new _build_command function messes with the ssh args I think. I couldn't get the script to work without adding the lxc_host variable which I think makes more sense for the plugin anyway.

stefangweichinger commented 3 years ago

testing it right now with debops.lxc

andreasscherbaum commented 3 years ago

@dmp1ce I added a test matrix for different Ansible versions: https://github.com/andreasscherbaum/ansible-lxc-ssh/pull/32 Can you rebase your patch please, and let's see if it works with all versions. Thanks!

andreasscherbaum commented 3 years ago

@dmp1ce Thanks for verifying. I have one last code question left, which is more a performance issue. See the inline comment please.

andreasscherbaum commented 3 years ago

Oh, and there is another PR merged in the meantime, that might require another rebase of your PR.

andreasscherbaum commented 3 years ago

Thanks for this PR! Really appreciated.