search

andreasscherbaum / ansible-lxc-ssh

Ansible connection plugin using ssh + lxc-attach
45 stars 22 forks source link

Add lxc_container option and documentation #39

Closed dmp1ce closed 3 years ago

andreasscherbaum commented 3 years ago

How can this be tested?

dmp1ce commented 3 years ago

I don't think the automated Github actions test lxc_hosts options currently. That is what we need to do for testing.

I tested locally for lxc_container and it worked for me.

AnvithLobo commented 3 years ago

https://github.com/andreasscherbaum/ansible-lxc-ssh/issues/37#issuecomment-858932351

https://github.com/AnvithLobo/ansible-lxc-ssh

I've written a test for it now feel free to refactor and adopt it how you see fit for this project.

andreasscherbaum commented 3 years ago

@dmp1ce Can you please rebase and push this PR, to fire the new tests again? Thanks.

dmp1ce commented 3 years ago

@dmp1ce Can you please rebase and push this PR, to fire the new tests again? Thanks.

👍

stefangweichinger commented 3 years ago

Ah, yes, I just wanted to vote for merging this one as well. Looks good also.