andreasvarga
commented
2 years ago I decided to remove completely the warnings. Is this OK for you?
Closed baggepinnen closed 2 years ago
andreasvarga
commented
2 years ago I decided to remove completely the warnings. Is this OK for you?
baggepinnen
commented
2 years ago That is okay!
andreasvarga
commented
2 years ago Did you update MatrixPencils as well to the last version v1.7.2 before performing the tests? If not, I would appreciate if you could execute the same tests again with this update performed, because I believe there should not be any warnings caused internally by DescriptorSystems and MatrixPencils. The situation is of course quite different if the warnings occured when you worked with an external tool (like Symbolics), where concatenations may produce such warnings.
Fredrik Bagge Carlson @.***> schrieb am Mi., 9. März 2022, 16:24:
With the latest version, the terminal frequently looks like this
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
┌ Warning: Type piracy in vcat: to be fixed in Julia 1.8 (make an issue otherwise)
└ @ DescriptorSystems ~/.julia/dev/DescriptorSystems/src/connections.jl:223
the maxlog=1 option will show the warning once only
You can view, comment on, or merge this pull request online at:
https://github.com/andreasvarga/DescriptorSystems.jl/pull/14 Commit Summary
- b4b7ac3 https://github.com/andreasvarga/DescriptorSystems.jl/pull/14/commits/b4b7ac3e62858d3fca5d6df69659dfa7b6da5cf9 Add maximum number of warning messages
File Changes
(1 file https://github.com/andreasvarga/DescriptorSystems.jl/pull/14/files)
- M src/connections.jl https://github.com/andreasvarga/DescriptorSystems.jl/pull/14/files#diff-40aa26d41b0c99b2f88018c7c8e914ee958ce3cb5e7fb1c11902eef04f06627f (4)
Patch Links:
- https://github.com/andreasvarga/DescriptorSystems.jl/pull/14.patch
- https://github.com/andreasvarga/DescriptorSystems.jl/pull/14.diff
— Reply to this email directly, view it on GitHub https://github.com/andreasvarga/DescriptorSystems.jl/pull/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJDHEHC3H7I6BLF2SARHR3U7C7CFANCNFSM5QJ3VU6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
With the latest version, the terminal frequently looks like this
the
maxlog=1option will show the warning once only