andreasvc / pyre2

Python wrapper for RE2
BSD 3-Clause "New" or "Revised" License
99 stars 33 forks source link

Support building wheels automatically using github actions #14

Closed yoav-orca closed 4 years ago

yoav-orca commented 4 years ago

Fixed #13 and also fixes another issue I encountered trying to use Poetry to install this package using git https://github.com/python-poetry/poetry/issues/3286

I hope this could be the basis for publishing a new package on PyPI

andreasvc commented 4 years ago

Thanks.

Actually Cython doesn't have to be a requirement because the package on pypi can include the generated c/cpp files: https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#distributing-cython-modules

yoava333 commented 4 years ago

It's a build dependency, it's only a dependency when building the package

andreasvc commented 4 years ago

Ahh I see. I registered the pyre2 package: https://pypi.org/project/pyre2/