search

andreasvc / pyre2

Python wrapper for RE2
BSD 3-Clause "New" or "Revised" License
99 stars 33 forks source link

tags and versions out of sync #29

Open sarnold opened 3 years ago

sarnold commented 3 years ago

Either we crossed each other on the last PR or I just plain missed a commit, but upshot is the v0.3.5 commit got orphaned and conda-forge wants to update to v0.3.6 but pypi only has v0.3.5 (the source version is still v0.3.5). I think the best answer is for me to make a PR with version updates and a typo fix for the release page, and then you'll need to delete both the v0.3.5 and v0.3.6 tags, then push a new v0.3.6 tag after the PR merge. Sorry for the inconvenience...

Delete local tag:

git tag --delete <ref_name>

Delete remote tag:

git push origin :<ref_name>
andreasvc commented 3 years ago

That sounds like a good plan. You mean that I should delete the tags before I accept your PR?

It's probably my fault. Having to specify the version in multiple places is error prone...

BTW: the github action correctly uploads wheels to pypi, but did not upload the source release.

And a very minor thing: the github releases have versions starting with "vv".

sarnold commented 3 years ago

Actually the conda package version is not so critical, since their automation almost takes care of itself. The PR should take care of that last 2 items above. I'm right in the middle of 17 different things (including trying to spin up a couple of new contracts) but hopefully I can push PR today.