search

andreasvc / pyre2

Python wrapper for RE2
BSD 3-Clause "New" or "Revised" License
99 stars 33 forks source link

win32 wheels #43

Open adityagoel4512 opened 1 year ago

adityagoel4512 commented 1 year ago

Currently it looks like wheels are not built for win32 (skipped in CI). Was there a reason I should be aware of for this, and would it be possible to support this in a new release?

andreasvc commented 1 year ago

I don't run Windows, so it's not something I would work on. I recommend to use WSL.

adityagoel4512 commented 1 year ago

I don't run Windows, so it's not something I would work on. I recommend to use WSL.

I'm happy to provide a PR that adds win32 builds in the CI. In principle I think it's possible and should be a relatively small change, I had a go here.

win32 release builds are necessary in a downstream project CI that would like to depend on this library so it would be very useful in that context. Would you be happy to accept a PR for this?

andreasvc commented 1 year ago

Sure

dmwyatt commented 9 months ago

@adityagoel4512 Did you ever get around to creating a PR?

sarnold commented 2 months ago

@adityagoel451 can you try the wheels here and see if they work for you?