Open sona-patel opened 1 year ago
Hi @sona-patel, yes you are right, in any case, I did some more improvements not yet released, such as adding an expanding shell geometry. If you are interested you can try the branch 'galactic_expanding_shell', but it is still experimental, even though a postdoc in Japan used it to reproduce the RS Ophiuchi results published in the MAGIC paper. I guess I will have something ready to experiment early next year, but if you are interested I can provide you with some notebooks after the Xmas break.
That's nice! I will also give more serious try early next year! - Thanks!
Hi @andreatramacere , I tested the 'galactic_expanding_shell' branch of Jetset! I can run smoothly galactic object models. However, I get the following errors while running the test:
==================================== test session starts ====================================
platform darwin -- Python 3.9.16, pytest-7.2.1, pluggy-1.0.0 -- /Users/sonal/anaconda3/envs/jetset_expanding_shell/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/sonal/test_jetset
plugins: anyio-3.5.0
collected 5 items
::TestUser::test_jet <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py
--------------------------------------------------------------------------------
model description:
--------------------------------------------------------------------------------
type: Jet
FAILED [ 20%]
::TestUser::test_emitters <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [ 40%]
::TestUser::test_dep_pars <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py FAILED [ 60%]
::TestUser::test_composit_model <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [ 80%]
::TestUser::test_composit_ebl <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [100%]
========================================= FAILURES ==========================================
_____________________________________ TestUser.test_jet _____________________________________
self =
Thanks!
@sona-patel, Hi, I did not finalise all the tests. I have pushed a change, now the test should work. You can test also multithreading, and it will be faster, for example, if you have a jet model you can:
jet._blob.N_THREADS=8
This will build 8 threads in the C code. On my laptop, with N_THREADS=8, I get ~ 3 times faster. This is still experimental, the thumb rule is to use N_THREADS~2*(number of your CPU cores)
These days I am super busy, but I should have a release during the next two months
Hi @andreatramacere,
Very glad to see the JetSet evolving so fast and now also having preliminary implementation for Galactic objects! 👏🏻
Isn't that the very first line on the documentation page should read as 1) GalacticBeamed to hadle galatcit objects that are
notbeamed 2) GalacticUnbeamed to hadle galatcit objects that are not beamed ?Thanks!