search

andrebaltieri / Flunt

Validations and Notifications
https://github.com/andrebaltieri/flunt
MIT License
626 stars 162 forks source link

Why Notification class is sealed? #41

Closed douglasangeli closed 3 years ago

douglasangeli commented 4 years ago

Is there a reasonable design requirement for the Notification.cs class to be sealed?

I ask this because I am using Flunt in a project that I need to have my own implementation.

Is there a problem with that?

andrebaltieri commented 3 years ago

Great question! When I designed it, I wanted to standardize the way notification outputs were shown, but theres a downside on it, which is that you cant extend Notification class.

On version 2 I`ll remove sealed modifier from Notification class.