search

andrebrait / 1g1r-romset-generator

A small utility that uses No-Intro DATs to generate 1G1R ROM sets
GNU General Public License v3.0
213 stars 20 forks source link

Hash checking might not work with NES ROMs. Handle Header information and check sums properly #12

Closed andrebrait closed 4 years ago

andrebrait commented 4 years ago

This is actually just a reminder for myself. Might generate a new version.

adlroux commented 4 years ago

Is it the same problem for FDS games?

andrebrait commented 4 years ago

Likely yes, but it should be fixed in 1.7.1 now. Do you have any issues with FDS?

adlroux commented 4 years ago

Indeed, even with 1.7.1, tested now, no FDS roms seems to pass. NES works like a charm however :)

andrebrait commented 4 years ago

Hmm... Reopening this then. I need to check FDS then

andrebrait commented 4 years ago

@glerouxlandr could you download the latest version from master and see if it works for FDS? It should, but I'll implement full support for header files later on

adlroux commented 4 years ago

@andrebrait It seems to work allright 👍 Well done! This is a very useful tool

andrebrait commented 4 years ago

@glerouxlandr I gave it a try with FDS and it works well. Could you please try using 1.8.0 and seeing if it works for you for the NES and FDS?