search

andrebrait / 1g1r-romset-generator

A small utility that uses No-Intro DATs to generate 1G1R ROM sets
GNU General Public License v3.0
220 stars 20 forks source link

--all-regions-with-lang ignoring parent-clone data #14

Closed HVR88 closed 4 years ago

HVR88 commented 4 years ago

I'm using a version downloaded sometime last month - this might be fixed in the new version, I'll have to check later.

Issue: When using the --all-regions-with-lang option the tool is allowing clones of an already accepted file to pass.

Example/Procedure to Duplicate Issue

Using SNES parent-clone DAT from DAT-O-Matic

Commandline arguments:

python3 generate.py -r USA,EUR -l en -e zip --all-regions-with-lang --prefer-parents --no-bios --no-program --no-enhancement-chip --no-beta --no-demo --no-sample --no-promo -d "SNES.dat" -i ../PATHIN -o ../PATHOUT

What I expect to happen

Files are grabbed in priority USA and then Europe and must have English Language - no clones. Files that are not included by this priority (from other regions) but have English language, should also be included.

"Not included" must account for being a clone of an already included title.

What is actually happening

Clones of titles already selected in the original priority are also included

Specific File Results

I get both Hebereke's Popoon from Europe AND Hebereke no Popoon from Japan. (And others like this)

HVR88 commented 4 years ago

Note: JPN was not included on the original priority list which is expected to work. I can test with JPN also specified to see if it makes a difference and helps find the root cause of this issue.

andrebrait commented 4 years ago

Could you post the specific DAT you used? That will help a lot.

Also, thanks for the detailed bug report :)

andrebrait commented 4 years ago

Huh, weird. At least with the latest SNES dat, I can't reproduce it.

I get the ones below:

Hebereke's Popoitto (Europe).zip
Hebereke's Popoon (Europe).zip

Could you download the latest version (1.9.0) and try it to see how it goes?

It's also going to use a much more accurate way of detecting the ROMs, though it will take a bit longer to process (but you can use the old way by adding --no-scan to the command).

HVR88 commented 4 years ago

Thanks for looking at this so quickly! I was planning to do a brand new filtering pass on my datable consoles, so I'm happy to try the latest version.

Let me see if I can attach or paste the dat I used. If there are any issues, I'll put it up for download somewhere.

HVR88 commented 4 years ago

OK, dat won't attach as the maximum comment is 64KB and the file is over 1MB. :) You can download it here: https://salumba.com/SNES.dat

andrebrait commented 4 years ago

Yeah, I still get the same ROMs with your dat. Let me know if it works.

HVR88 commented 4 years ago

I just downloaded a few minutes ago - how can I check the version?

andrebrait commented 4 years ago 
python3 generate.py -v

:-)

andrebrait commented 4 years ago

If the version is >1.9.0, that is. Because I just introduced that

HVR88 commented 4 years ago

OK, because I had already tried that. :) I was worried I didn't move the files over to my server.

HVR88 commented 4 years ago

Seems to work as expected now and omits the Japanese clones I noticed earlier.

andrebrait commented 4 years ago

Ok, I'm closing this then :+1: