andrebrait / 1g1r-romset-generator

A small utility that uses No-Intro DATs to generate 1G1R ROM sets
GNU General Public License v3.0
220 stars 20 forks source link

Getting a warning of file not found for a file that shouldn't be considered #15

Closed HVR88 closed 3 years ago

HVR88 commented 4 years ago

This might not be a bug, depending on whether you first output text for files found in the source folder matching the dat before evaluating them

Platform: Sega Genesis DAT: current P/Clone generated today at dat-o-matic

Error message: WARNING: candidate [Puyo Puyo Tsuu (Europe) (Ja) (Rev A) (Virtual Console).zip] not found, trying next one WARNING: no eligible candidates for [Puyo Puyo Tsuu (Japan) (Rev A)] have been found!

Parameters: python3 generate.py -r CAN,USA,EUR -l en -e zip --all-regions-with-lang --prefer-parents --no-bios --no-program --no-enhancement-chip --no-beta --no-demo --no-sample --no-promo -d "DAT/SegaGenesis.dat" -i ../source -o ../destination

So the files warned about should be excluded given the "en" language setting. I just found it curious the errors were output at all given this restriction.

andrebrait commented 4 years ago

Any ETA ? :)

[now, 2021) 😅

HVR88 commented 4 years ago

if (completion < NOW) ETA = "already done"; else if (completion >= NEVER) ETA = "don't hold your breath"; else if (completion < 2021) ETA = "this year"; // aka soon else ETA = "eventually";

mspykerez commented 4 years ago

My Nintendo Switch is waiting to load RetroArch and every bit of space counts! Need it ASAP, No pressure!

mspykerez commented 4 years ago

Any progress you can tell us about? Are you working on an installer and GUI?

andrebrait commented 4 years ago

No installer and no GUI. Currently, I'm just refactoring what's already there.

I have added support for tar.gz, tar.bz2, tar.xz, uncompressed tar, rar and 7z archives, with zip refactored too. I'm adding a bunch of options to recompress (only zip and 7z supported, however), generate a custom DAT as output, choice of folder/archive structures, etc.

Right now, I'm redoing the CLI so it's way easier to expand and change as needed. Just refactoring a lot of code.

All modes will support all methods by which ClrMamePro identifies ROMs (size + crc, md5 and sha1 checksums), with fallback by name. I'm sorry for not adding this sooner, but right now it's not super easy to add, hence the refactoring happening first.

mspykerez commented 4 years ago

Nice! Keep it going.

HVR88 commented 4 years ago

All sounds good. Tool was already working quite brilliantly and simply for sorting out 1G1R. I really can't stand clrmamepro. As a long-time SW designer, its absolutely horrific UI and UX make my head spin.

mspykerez commented 4 years ago

Meanwhile new RetroArch version was released... & you guys are slacking with your releases!!

andrebrait commented 4 years ago

@mspykerez Oh, boy, if only this was not a one-man project which someone does in their free time :joy:

It's coming together. Be patient :wink:

...or learn yourself some Python and submit a PR :sweat_smile:

mspykerez commented 4 years ago

👍