andrebrait / 1g1r-romset-generator

A small utility that uses No-Intro DATs to generate 1G1R ROM sets
GNU General Public License v3.0
213 stars 20 forks source link

Input folder handling is broken (Windows and macOS) #23

Open basvroegop opened 4 years ago

basvroegop commented 4 years ago

I've been trying to get this generator to work, but keep stumbling into the same problem: it won't recognize the input folder. I've tried it with and without quotes, but no luck. My guess is it's due to my operating system. I'm on macOS, but all the examples in the wiki are based on Windows, where the folder structuring is different.

andrebrait commented 4 years ago

Hmm, it shouldn't matter. I mostly use it on Linux, which shares a similar UNIX-like filesystem structure with macOS.

Could you post the command you're trying to run?

basvroegop commented 4 years ago

Sure thing, here's one I tried:

python3 generate.py -r USA,EUR -l en -e zip --exclude "Virtual Console,GameCube" --no-all --all-regions-with-lang -d "Nintendo - Super Nintendo Entertainment System (Combined) (Parent-Clone) (20200422-231754).dat" -i "/Users/bas/Desktop/SNES" -o "/Users/bas/Desktop/SNES-1G1R"

Tried removing the quotes, removing the / at the start or adding one at the end, no combination seems to stick.

andrebrait commented 4 years ago

Does it give you an error regarding the existence of the folder or does it try to scan the folder but finds nothing?

If the latter, could you add --debug to the command and send me the generate.log file?

jcarr71 commented 4 years ago

I'm having the same issue on Windows 10 using PowerShell. I can use the program all the way up until I attempt to add an input directory. Here's the command I am using :

python generate.py -r USA,EUR -l en -e zip --no-all --all-regions-with-lang -d "F:\1g1r\DAT Files\Atari - 2600 (Parent-Clone) (20200514-091155).dat" -i "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)" -o "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)\1g1r"

I've added --debug, but nothing shows in the generate.log file. It's like it get's to the -i portion and just stops and drops back to the command line. Also, every time it drops back to the command line it displays the help screen, like the argument isn't formatted correctly or something. I've also changed everything to be as simple as possible, but it still happens. For example :

python generate.py -r USA,EUR -e zip -d "F:\1g1r\DAT Files\Atari - 2600 (Parent-Clone) (20200514-091155).dat" -i "F:\Atari 2600"

Does the same thing. I AM able to do a preview with just the DAT file, but once I add anything beyond -i it bombs.

andrebrait commented 4 years ago

I'm going to look into this. I think handling of paths is wrong somewhere

On Tue, Jun 9, 2020, 19:04 jcarr71 notifications@github.com wrote:

I'm having the same issue on Windows 10 using PowerShell. I can use the program all the way up until I attempt to add an input directory. Here's the command I am using :

python generate.py -r USA,EUR -l en -e zip --no-all --all-regions-with-lang -d "F:\1g1r\DAT Files\Atari - 2600 (Parent-Clone) (20200514-091155).dat" -i "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)" -o "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)\1g1r"

I've added --debug, but nothing shows in the generate.log file. It's like it get's to the -i portion and just stops and drops back to the command line.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/andrebrait/1g1r-romset-generator/issues/23#issuecomment-641450793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLX5OVNULYFREAG2MBFR53RVZTS5ANCNFSM4MRXOAEA .

andrebrait commented 4 years ago

For now, could you try using forward slashes instead of backslashes?

Either that or escape the backslashes by putting another one in front of them, like this: \\

On Tue, Jun 9, 2020, 19:04 jcarr71 notifications@github.com wrote:

I'm having the same issue on Windows 10 using PowerShell. I can use the program all the way up until I attempt to add an input directory. Here's the command I am using :

python generate.py -r USA,EUR -l en -e zip --no-all --all-regions-with-lang -d "F:\1g1r\DAT Files\Atari - 2600 (Parent-Clone) (20200514-091155).dat" -i "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)" -o "F:\1 - No Intro Rom Validated Sets\Atari - 2600 (20200514-091155)\1g1r"

I've added --debug, but nothing shows in the generate.log file. It's like it get's to the -i portion and just stops and drops back to the command line.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/andrebrait/1g1r-romset-generator/issues/23#issuecomment-641450793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLX5OVNULYFREAG2MBFR53RVZTS5ANCNFSM4MRXOAEA .

jcarr71 commented 4 years ago

I've tried escaping the backslash, using forward slash, reducing the argument to just Atari2600 directory so no spaces or special characters. Not sure what else I can try? Let me know if there's something you can think of you may need to help you investigate. Thanks!

andrebrait commented 4 years ago

Ok. Thanks a lot.

I'll see if I can change one thing tomorrow and then you can download the code from the repository and check if it works. I'll post here when the code is live.

andrebrait commented 4 years ago

Another user has reported the same issue to me in an email. I'll make a fix to v1.9 and I'll see if I can release it today.

andrebrait commented 4 years ago

@basvroegop @jcarr71 could you please download the latest code from the master branch and try it? It should be fixed now that master also uses Python's pathlib

jcarr71 commented 4 years ago

Worked for me, however I had to remove "-e zip", otherwise it would return "extensions cannot be used when scanning". I can't recall why I had it in my line in the first place, and not exactly sure what the argument does, so may be what it's supposed to do. Thanks for the update!

andrebrait commented 4 years ago

@jcarr71 yeah, that was expected :sweat_smile: Could you re-test again with the latest release I have and let me know if it works? I'll close the issue if it does. Thanks!

jcarr71 commented 4 years ago

I actually had to reload my laptop for another reason and haven't installed Python yet, but maybe the OP can test it for you? I'll check back when I get things set up to see if he has, and if not, I will. Thanks for the update!