search

andrebrait / 1g1r-romset-generator

A small utility that uses No-Intro DATs to generate 1G1R ROM sets
GNU General Public License v3.0
213 stars 20 forks source link

Does not work on 7zipped files, needs to be extracted to work. #33

Open Elijah067 opened 3 years ago

Elijah067 commented 3 years ago

I tried to use this on my DS no-intro set which is 7zipped but the generator says that WARNING: no eligible candidates for <rom name> have been found!. I tried to extract the roms and the generator works fine.

I also tried --no-scan on the 7zipped rom files and it also does not work. Maybe due to the file extensions.

andrebrait commented 3 years ago

Indeed, it cannot check the contents of 7-zip archives. That is already implemented in DATROMTool and it does work, but it won't be implemented in 1g1r-romset-generator.

If you want to use --no-scan with compressed files, you need to add -e 7z so it knows it can match .7z files by name. Otherwise, it'll look only for .nds files (or whatever happens to be the extension used in the DAT you're using).

jvook commented 2 years ago

ROMSorter will convert 7z and rar rom collections to standard zip so they work with 1g1r generator script https://github.com/drakewill-CRL/ROMSorter

andrebrait commented 2 years ago

@jvook just a FYI, I have something in the works for that as well :)