[Bug Report] Feats-1 codex improved shield bash and Gambit ally status berserk typos

andrecronje / rarity

d20srd reference implementation codified in solidity

Other

610 stars 121 forks source link

Closed JuffuJuffu closed 3 years ago

JuffuJuffu commented 3 years ago

In the codex feats 1 (https://github.com/andrecronje/rarity/blob/main/codex/codex-feats-1.sol) at ID 64 "Improved Shield Bash" the "prerequisites_feat = 64;" <-- Is set to 64, which is the ID for this same feat. It should probably be 63 which is the shield proficiency.

Also in Codex Gambits (https://github.com/andrecronje/rarity/blob/main/codex/codex-gambits.sol) there is in a double space in line 58 "return (_id, 0, "Ally: Status: Berserk"); dunno if this matters or not :D

JuffuJuffu commented 3 years ago

Also found that Spell Penetration feat is twice in the codexes. The duplicate is found in Codex-2 ID 92 row 556

JuffuJuffu commented 3 years ago

Made a pull request. ill close this.