andrecronje / rarity

d20srd reference implementation codified in solidity
Other
610 stars 121 forks source link

Sling icon/asset potentially missing #93

Closed ghost closed 3 years ago

ghost commented 3 years ago

I have just crafted a sling on my warrior, and i noticed that the image asset for the sling is missen, or broken, ive attached an image aswell for display image

I also don't believe the sling is suppose to weigh 0.

steveocrypto commented 3 years ago

This looks to be on raritymmo.com. Can you please try clearing your browser cache and refreshing the page, see if that fixes it?

How to clear cache

The weight being reported from the contract is 0 though. Just checked that.

ghost commented 3 years ago

Issue persists after clearing browser cache.

Also yeah, I play on raritymmo.com for confirmation

steveocrypto commented 3 years ago

Thanks for trying that. What browser are you using? And can you right-click on the picture and post what URL it's trying to access for me?

ghost commented 3 years ago

I am using Google chrome version 94.0.4606.71(64-bit)

and its trying to access the following url

https://raritymmo.b-cdn.net?width=48&aspect_ratio=1:1

steveocrypto commented 3 years ago

https://raritymmo.b-cdn.net?width=48&aspect_ratio=1:1

This is the culprit - looks like it's excluding the name of the image. I'm on it!

steveocrypto commented 3 years ago

Can you go ahead and refresh, let me know if you see it fixed?

Note that this is one of the items that I wasn't able to find the perfect icon for, so it does use the default weapon image for now. There's a handful that I just couldn't find (like nunchucks), and this is a good reminder to check on that again.

ghost commented 3 years ago

Fixed! thank you!