andredias / perfect_python_project

43 stars 12 forks source link

poetry.lock should be part of the template #6

Closed andredias closed 1 year ago

andredias commented 1 year ago

Since pyproject.toml does not record any version restrictions, we need poetry.lock to define the currently used versions. Otherwise, we cannot guarantee that a newly created template instance will run. For example, fastapi-complete doesn't work with databases 0.8.0 yet but this version will be used during the template instantiation anyway because of the lack of a restriction in pyproject.toml or in poetry.lock.

I prefer to keep pyproject.toml the way it is, so it will be possible to run poetry update to update all dependencies to their latest versions anytime.

andredias commented 1 year ago

fixed in bd096f8