andrefaraujo / videosearch

Large-scale video retrieval using image queries.
289 stars 105 forks source link

Are there serveal too big array? #9

Closed pkdog closed 6 years ago

pkdog commented 6 years ago

In the file named sift_extractor.cc. vl_sift_pix* data = new vl_sift_pix[number_pixels*sizeof(vl_sift_pix)];//line 61 float* this_frame = new float[4*sizeof(float)];//line 170 float* this_descr = new float[128*sizeof(float)];//line 171 The size of them is it too big? Maybe it can do like that: vl_sift_pix* data = new vl_sift_pix[number_pixels];//line 61 float* this_frame = new float[4];//line 170 float* this_descr = new float[128];//line 171 I'm coding my graduation project which refer to your project. I'm a little confused about this problem.

andrefaraujo commented 6 years ago

Hi @pkdog , I think you are correct. Does it work for you with the suggested changes? I'd be happy to review a pull request and integrate it in the codebase.

andrefaraujo commented 6 years ago

Closing due to inactivity, please reopen if necessary.