andrefoo / pe

0 stars 0 forks source link

Adding same name is possible #1

Open andrefoo opened 12 months ago

andrefoo commented 12 months ago

image.png

The application allows adding same name with different number of spaces in between the subnames.

User Guide mentions that this is not allowed:

image.png

This could be problematic for a user if the TA is adding names through an excel sheet, and accidentally types in the same name with different spaces. This would lead to data inaccuracies, if one name is updated and the duplicate is not. This could lead to inaccurate grading if updating of data is done occasionally on 1 duplicate and occasionally on the other.

soc-se-bot commented 11 months ago

Team's Response

Thank you for your concern. It is understandable that this may have a potential typo in duplicating names for the user.

However, making a typo in terms of spacing such that it would allow for duplicating names is quite unlikely, and here are some cases to consider:

Case 1: Student is the only student that so happens to have that name -> No issues of duplicate names.

Case 2: Student has duplicate names reproduced by the typo above. The student would have been put in a duplicate entry. -> This is almost a non-issue as the user would have to grade using the index of the student either way, which is unique.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Case 1 could still result in inaccuracies: Alex Yeoh attendance is updated for first 5 weeks Alex Yeoh (duplicate) attendance is updated for the next 5 weeks

When updating Canvas for attendance marks, one Alex Yeoh is referenced - and it would show that he has only attended 5 tutorials out of 10 that he attended.

Case 2 still might result in inaccuracies - with duplicate names, Case 1 might still occur.