search

andrehaveman / spotify-node-applescript

Control Spotify on Mac OSX with NodeJS and AppleScript
MIT License
316 stars 38 forks source link

Promise support #24

Open kahluagenie opened 8 years ago

kahluagenie commented 8 years ago

Currently this easily works with Bluebird.promisifyAll(require('spotify-node-applescript')), but I think it would be fantastic if the library supported promises out of the box.

markstickley commented 8 years ago

Seconded. I'm currently wrapping all callback functions in my code to give promise functionality!

matthewnitschke commented 7 years ago

I have created a fork which supports Promises. You can find it here.

Unless you guys think otherwise, I don't think I will create a pull request for it because the changes remove callback functions, making it not backwards compatible.

lucasbento commented 7 years ago

@matthewnitschke: awesome, can you add it to npm so others can use it easily? can be under spotify-node-applescript-promise name.

matthewnitschke commented 7 years ago

@lucasbento just added it. Can be downloaded via

npm install spotify-node-applescript-promise