search

andrehaveman / spotify-node-applescript

Control Spotify on Mac OSX with NodeJS and AppleScript
MIT License
316 stars 39 forks source link

Implement jumpTo method #5

Closed rmehner closed 11 years ago

rmehner commented 11 years ago

This implements a jumpTo method to jump to a specific position of the song. Example:

spotify.jumpTo(15, function() {
  console.log('Jumped 15th second of the song');
});

The test is not optimal now as we need a timeout to give spotify some time to catch up from the beforeEach "playTrack", but I wanted to keep this change small.

rmehner commented 11 years ago

Hey there, any reason why this is not merged yet? Something wrong with the code? Anything I should improve?

Thank you :)

rmehner commented 11 years ago

Hey, I just saw that there was a merge conflict due to the refactorings. I just fixed them and did a force push. You should be able to single-click merge them now.

andrehaveman commented 11 years ago

I merged it. Thanks for the contribution.

rmehner commented 11 years ago

Thank you for fixing the documentation, just wanted to commit something to fix that too.