andrei-drexler / ironwail

High-performance QuakeSpasm fork
GNU General Public License v2.0
480 stars 43 forks source link

process can hit max open files limit when loading save games #320

Closed j4reporting closed 1 week ago

j4reporting commented 1 week ago

Something is going very wrong with the handling of pak files.

how to reproduce:

  1. ironwail -game ad
  2. map ad_magna
  3. save quick
  4. keep reloading with the F key until message error: couldn't open appears

image

at his point any load or save will fail and load/save menu will not show any existing save files s[0-19].sav
not reproducible in qspasm

each map start or load of savegame will leak additional filedescriptors for AD/pak0.pak file

Process monitor shows many ClossFile lines at process end for ad/pak0.pak with this filter

image

andrei-drexler commented 1 week ago

Thanks for the detailed report! Should be fixed in 3ce9048874434f70012072c2d3747501c27943cd.