Closed rgerrans closed 4 years ago
@andrei-tatar I realized this never got pulled. Seems to be working fine on my deployment. Let me know any issues or concerns.
@andrei-tatar Let me know if I need to do anything else to this for you to pull (other than clean up the one conflict with the version number)?
@rgerrans did you manage to test it? I think it looks good. I can merge it once the conflict is resolved.
I've been using it for 2 1/2 months and seems to work fine. I fixed the version number in my branch. so should be good to go. I did want to flag my earlier comment:
- I changed the configuration layout of the html file for the Lock node config. If you prefer a different structure, please feel free to edit. Or if you like this structure, I'm happy to apply it to the other nodes.
@rgerrans merged and published 0.0.33 Thanks for the contribution! :)
@andrei-tatar Happy to help. I need to get back on the fan work one of these days when life slows down a little....Thanks for all your work getting this up and maintaining it.
Everything seems to be testing out right on my system.
A couple of quick notes:
deviceJammingDetected
error response, thought I kind of assumed that would have been handled by Google to not lock/unlock if isJammed is set to True?