search

andrei1058 / BedWars1058

A minecraft minigame where you have to defend your bed and destroy the others. Once your bed is destroyed, you cannot respawn.
GNU General Public License v3.0
270 stars 213 forks source link

spawnLimit in ore gens isnt used right when stacking items #858

Open IIHERO4 opened 1 year ago

IIHERO4 commented 1 year ago

I believe this should be += i.getItemStack().getAmount() instead of ++

https://github.com/andrei1058/BedWars1058/blob/9a0c4380d2f0d2aa4dcb98798d3bea5d158c525b/bedwars-plugin/src/main/java/com/andrei1058/bedwars/arena/OreGenerator.java#L160

andrei1058 commented 1 year ago

Why?

andrei1058 commented 1 year ago

oh wait, is this related to the stack items option?

andrei1058 commented 1 year ago

but it only counts drops. I don't get it

IIHERO4 commented 1 year ago

but it only counts drops. I don't get it

Vanilla Minecraft I believe group some items to one item stack, so instead of two entities with amount of 1, it will make 1 entity with amount of 2

To be fair i dont remember if i used a spigot fork or not but when i printed the itemStack.getAmount it wasnt always 1