andreiDamoc / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Removing future deprecated files passes 1.2.7 validator & fails at PCFE #289

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. acting upon this "Column agency_lang in file agency.txt is deprecated" & 
"Column agency_timezone in file agency.txt is deprecated" & should not be used 
in new feeds
2.I removed those fields & kept the related data in feed_info
3.Feed passes both validators
4.post the file to PCFE
5.Failed feed due to missing files in agency.txt: Error, InvalidValue: Invalid 
value None in field agency_timezone
"None" is not a common timezone name according to pytz version 2010h at 
agency.txt:2 column agency_timezone
Error, MissingColumn: Missing column agency_timezone in file agency.txt at 
agency.txt:1 column agency_timezone
Error, MissingValue: Missing value for column agency_timezone at agency.txt:2 
column agency_timezone

What is the expected output? What do you see instead?
If feed passes validator I expect the feed to pass PCFE

I see failed feed:
Error, InvalidValue: Invalid value None in field agency_timezone
"None" is not a common timezone name according to pytz version 2010h at 
agency.txt:2 column agency_timezone
Error, MissingColumn: Missing column agency_timezone in file agency.txt at 
agency.txt:1 column agency_timezone
Error, MissingValue: Missing value for column agency_timezone at agency.txt:2 
column agency_timezone
Warning, UnknownFile: The file named feed_info.txt was not expected.
This may be a misspelled file name or the file may be included in a 
subdirectory. Please check spellings and make sure that there are no 
subdirectories within the feed at feed_info.txt
Warning, UnrecognizedColumn: Unrecognized column agency_fare_url in file 
agency.txt. This might be a misspelled column name (capitalization matters!). 
Or it could be extra information (such as a proposed feed extension) that the 
validator doesn't know about yet. Extra information is fine; this warning is 
here to catch misspelled optional column names. at agency.txt:1 column 
agency_fare_url

What version of the product are you using? On what operating system?
transitfeed-windows-binary-1.2.7.zip
windows 7

Please provide any additional information below.
I'm not clear why agency_fare_url is reported as "unrecognized column" in the 
version 1.2.7; but since not an error or failure its a minor concern

thank you for clarifying so that I can tune up my GTFS output tools

Original issue reported on code.google.com by action...@gmail.com on 9 May 2011 at 3:40

GoogleCodeExporter commented 8 years ago
Hi unfortunately PCFE is still running FeedValidator 1.2.6. The update should 
happen soon.
Regular updates of the FeedValidator should be backwards-compatible but in the 
case of the deprecated column feature that somehow was not possible.
Please keep the column agency_timezone in your file agency.txt until PCFE is 
updated.
Sorry for the trouble and thanks for your understanding.
Best regards,
Moritz

Original comment by n...@google.com on 9 May 2011 at 3:49

GoogleCodeExporter commented 8 years ago
It may be helpful to test feed_info for data during validation 1.2.7

I experienced that feed validates with blank row for data but then also fails 
at PCFE (as explained above) perhaps the feedvalidator 1.2.7 could test for 
blank row in feed_info?

Original comment by action...@gmail.com on 5 Jun 2011 at 2:26

GoogleCodeExporter commented 8 years ago

Original comment by n...@google.com on 14 Jun 2011 at 1:20

GoogleCodeExporter commented 8 years ago

Original comment by bdfer...@google.com on 26 Sep 2014 at 4:47

GoogleCodeExporter commented 8 years ago
Moved to https://github.com/google/transitfeed/issues/289

Original comment by bdfer...@google.com on 7 Oct 2014 at 7:37