search

andreicristianpetcu / google_translate_this

This WebExtension translates the current page with Google Translate. It does so on demand so it does not change the page unless the user selected this. It is fast, light and privacy friendly.
https://github.com/andreicristianpetcu/google_translate_this/releases
GNU General Public License v3.0
190 stars 10 forks source link

Android support #8

Closed Overstuff1260 closed 5 years ago

Overstuff1260 commented 5 years ago

Hey mate, was just here asking if you have any news about mobile development. I use this so much on desktop, and I urgently need it on mobile too. Thanks

Overstuff1260 commented 5 years ago

Sorry also if this is a bad sector to ask this

andreicristianpetcu commented 5 years ago

Fair question. I have no deadline for it. I would like to implement support some time but until then you can use this one https://github.com/jeremiahlee/page-translator

Overstuff1260 commented 5 years ago

I didn't know about that one, thanks a lot for the heads up. Will still continue to use yours on desktop though ❤️

andreicristianpetcu commented 5 years ago

Thank you @dav9597 !

andreicristianpetcu commented 5 years ago

Damn! It was A LOT easier than I was expecting :D test it out

Also on the releases page https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.2.2

andreiuipath commented 5 years ago

There is one issue I don't feel like fixing: selecting the language the first time is a pain Screenshot_20190818-013710_Firefox Switch to desktop, select language, switch back to mobile Screenshot_20190818-013721_Firefox

Overstuff1260 commented 5 years ago

Ok, it works. I just find it disturbing that it reloads the page, instead of just instant translating it

andreicristianpetcu commented 5 years ago

@dav9597 It only does that for pages with content security policy. For pages without csp it should just translate.

This reload was the solution I found for this https://github.com/andreicristianpetcu/google_translate_this/issues/6

andreicristianpetcu commented 5 years ago

I fixed the latest issue. Also I learned that it's better to have different extensions for android and desktop. Please uninstall on android and reinstall. Future updates for android will work normally https://github.com/andreicristianpetcu/google_translate_this/releases/download/v2.2.8/google_translate_this_page-2.2.8-an.xpi

Overstuff1260 commented 5 years ago

Seems like I don't need page translator anymore 😏😉