andreicristianpetcu / google_translate_this

This WebExtension translates the current page with Google Translate. It does so on demand so it does not change the page unless the user selected this. It is fast, light and privacy friendly.
https://github.com/andreicristianpetcu/google_translate_this/releases
GNU General Public License v3.0
190 stars 10 forks source link

option to turn off "always translate" for a domain (from latest update) #9

Closed mkeroppi closed 5 years ago

mkeroppi commented 5 years ago

Thanks.

HappyTrix commented 5 years ago

yes please

GregoryPINAULT commented 5 years ago

Hello,

I encounter the same issue. Once translated one time, all pages of a domain are translated, even when a i don't want it.

The option to turn off "always translate" don't work.

The old behaviour (translating only when I ask for it) was far better.

Thanks

andreicristianpetcu commented 5 years ago

Damn! I had no clue the old behavior was desirable for some people :D I will implement it the next time I get to work on it.

I would like to keep domain translation as default. How do you prefer the feature?

1) one time translate option in browser action (the icon in top right) 2) one time translate option for page action (the icon in the url bar) not sure if this is possible 3) one time translate keyboard shortcut 4) option page where you choose if you always want to translate domain or always want to translate the page once 5) any other idea?

andreicristianpetcu commented 5 years ago

try this extension, maybe it will work until I fix this issue https://github.com/jeremiahlee/page-translator

GregoryPINAULT commented 5 years ago

Damn! I had no clue the old behavior was desirable for some people :D I will implement it the next time I get to work on it.

I would like to keep domain translation as default. How do you prefer the feature?

1. one time translate option in browser action (the icon in top right)

2. one time translate option for page action (the icon in the url bar) not sure if this is possible

3. one time translate keyboard shortcut

4. option page where you choose if you always want to translate domain or always want to translate the page once

5. any other idea?

I think the option 4 would be the best.

andreicristianpetcu commented 5 years ago

I was also thinking about 4 but wanted to see other opinions.

mkeroppi commented 5 years ago

I like 2 in addition to 4. Better yet, if the option could be turned off/on by domain.

andreicristianpetcu commented 5 years ago

Here is the mockup of what I'm working on. image image

andreicristianpetcu commented 5 years ago

Here is the new beta with this feature. Please test https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1 @mkeroppi @GregoryPINAULT @HappyTrix

GregoryPINAULT commented 5 years ago

Here is the new beta with this feature. Please test https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1 @mkeroppi @GregoryPINAULT

The option page works ! On Firefox ESR for Windows at least. Thanks. Having options for default behaviour is pretty useful.

jcosentino commented 5 years ago

Thanks for considering this change! I just wanted to chime in that the reason I liked the old way is so that I can translate a page with foreign text that might not necessarily be in another language. For example: a Youtube video with a lot of international people commenting in different language, or the comment section on a Facebook page with different languages.

andreicristianpetcu commented 5 years ago

Did you try the beta @jcosentino ? https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1

I need to test it a bit more until I ship it as an update.

jcosentino commented 5 years ago

Did you try the beta @jcosentino ? https://github.com/andreicristianpetcu/google_translate_this/releases/tag/v2.3.1

I need to test it a bit more until I ship it as an update.

I have. So far, it seems to work with the new option of translating only once. However, with that option enabled, it still says "Always translate [website]" even though it does not, as intended.

andreicristianpetcu commented 5 years ago

I'll release a fix next week for this. Thank you for testing @jcosentino