search

andreicuceu / vega

GNU General Public License v3.0
9 stars 5 forks source link

Compute zeff #126

Open cramirezpe opened 1 year ago

cramirezpe commented 1 year ago

We would like to compute the value of zeff from the correlation output files.

I created this branch as a fork since I have no permissions in this repo.

I pass the full CorrelationItem object to the function in order to select the correct r-min/r-max for each correlation, although I guess nobody is going to run different r-min/r-max in the same run..

Let me know what you think,

calumgordon commented 3 weeks ago

@cramirezpe @andreicuceu Should we try and do the necessary steps to introduce this?

andreicuceu commented 3 weeks ago

@calumgordon I think this outdated. We don't actually measure the effective redshift like this anymore. So we should probably close this pull-request and create an issue for someone to implement the actual way we do it.