codecov[bot]
commented
1 year ago Codecov Report
Attention: 330 lines in your changes are missing coverage. Please review.
Comparison is base (
9ba6e10) 46.40% compared to head (542ed82) 42.63%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #131 +/- ## ========================================== - Coverage 46.40% 42.63% -3.77% ========================================== Files 25 27 +2 Lines 3140 3373 +233 Branches 602 658 +56 ========================================== - Hits 1457 1438 -19 - Misses 1560 1807 +247 - Partials 123 128 +5 ``` | [Flag](https://app.codecov.io/gh/andreicuceu/vega/pull/131/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrei+Cuceu) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/andreicuceu/vega/pull/131/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrei+Cuceu) | `42.63% <34.78%> (-3.77%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrei+Cuceu#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR introduces metal matrix computation in vega using the fast metals approach from picca that only considers the rp dependence of the metal matrices. When computing metal models, Vega now requires a catalog with stacked weights for continuous tracers and a catalog with object redshifts for discrete tracers.
This PR also introduces an overhaul of the coordinate grid handling. There is a new class that stores coordinate grids, and Vega now works with different instances of this class.