search

andreika-git / hellen-one

Hellen-One Hardware Platform for rusEFI Engine Management System
21 stars 29 forks source link

schematics usability - "D104" placement is confusing (was about green fatal) #143

Open rusefillc opened 2 years ago

rusefillc commented 2 years ago

PDF says green is D105 and red is D104

image

rusefillc commented 2 years ago

https://rusefi.com/docs/ibom/alphax_2ch-b-ibom.html

ibom says D104 is D104 and D103 is red

image

rusefillc commented 2 years ago

while we are fixing this I suggest usability improvement:

instead of LED1-4 let's have LEDR LEDG LEDB LEDY or LED_R LED_G LED_B LED_Y in the schematics

rusefillc commented 2 years ago

@andreika-git what's your take on this issue? does it look like schematics is wrong while ibom is right?

andreika-git commented 2 years ago

image

Both the schematics and iBOM are correct. The label positions on schematics are confusing: a designator is on top of a component and value is on bottom.

rusefillc commented 2 years ago

green LED was a SW issue https://github.com/rusefi/rusefi/commit/9de0c10f24f9f587f0179a4230439f8a1fd08144