andreika-git / hellen-one

Hellen-One Hardware Platform for rusEFI Engine Management System
21 stars 28 forks source link

Command line gerber export touches project files #307

Closed rusefillc closed 1 year ago

rusefillc commented 1 year ago

https://github.com/rusefi/hellen88bmw/commit/6149333b9ca89f442df8c9704b6ae35eb649b11c has touched .kicad_pro file

Do we have any concerns or do we keep thing as is?

rusefillc commented 1 year ago

One potentially negative consequence I can think of - at the moment we install latest kicad thus at any moment of time fresh GHA might invoke latest and greatest and overwrite the file. This might well be bad timing forcing engineer to update his local install. @chuckwagoncomputing @Qwerty-OFF @andreika-git what do you think?

chuckwagoncomputing commented 1 year ago

Yes this needs to be fixed