andreika-git / hellen-one

Hellen-One Hardware Platform for rusEFI Engine Management System
21 stars 28 forks source link

export.sh should print helpful message if aux_axis_origin is missing #317

Closed rusefillc closed 1 year ago

rusefillc commented 1 year ago

export.sh

echo Getting Drill/Place origin from PCB
X=$(grep "aux_axis_origin" "$PCB_FILE" | tr -s ' ' | cut -d ' ' -f 3)
Y=$(grep "aux_axis_origin" "$PCB_FILE" | tr -s ' ' | cut -d ' ' -f 4 | tr -d ')')
echo Export VRML using $X $Y
python "$DIR/export-vrml.py" "$PCB_FILE" "$X" "$Y" "gerber/$IN.wrl"

See https://github.com/rusefi/stim/actions/runs/5734128619/job/15539845060 which has failed

Export VRML using
Traceback (most recent call last):
  File "/home/runner/work/stim/stim/digital_inputs/../hellen-one/kicad/bin/export-vrml.py", line 8, in <module>
    x = float(sys.argv[2])
ValueError: could not convert string to float: ''

i.e. aux_axis_origin has produced empty $X $Y

rusefillc commented 1 year ago

https://github.com/rusefi/stim/issues/21