search

andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

ADD open terminal plugin #113

Closed y0no closed 11 years ago

y0no commented 11 years ago

It's not really clear, but if that can help someone.

andreikop commented 11 years ago

Thank you very much!

I've made few fixes. Review it please. I also created a Hacking guide

And one more thing: it is quite difficult to check if terminal really opened, but if you managed to write tests for the plugin, it would be cool. There are no docs about testing currently. Check tests directory at the root of the repository for examples.

y0no commented 11 years ago

you're welcome!

I will write test for the plugin as soon as possible. I have review the code and only have seen a useless line (I think). I have put a comment on the commit, I don't know if you can view it ?

andreikop commented 11 years ago

Do you mean os.getcwd()? Yes, I've seen it. It might be removed probably. Enki changes current directory, when current file is switched, so, this code works just like your version.

y0no commented 11 years ago

Ok nice! =)