andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

Enki should refer to Qutepart as Git submodule #115

Closed vi closed 11 years ago

vi commented 11 years ago

There are a lot of times when something being added to Qutepart and Enki together. They should be linked more strongly (because of not just "Enki uses Qutepart", but also "Enki and Qutepart are developed together").

Hovewer there are currently no good way to tie them together except by date. Bisecting Enki is also complixified by the need to manually adapt Qutepart for every step.

There should be submodule in Enki repository so that each time some new Enki commit depends on some new Qutepart commit, submodule gets updated.

That way after checking some intermediate version of Enki we will get the appropriate version of Qutepart.

If you really hate submodules, you can manually maintain Qutepart's commit ID in Enki's README (or something). It will be "poor man's git submodules".

vi commented 11 years ago

Now Enki and Qutepart as 2 separate projects and I'm not going to include Qutepart to Enki source package and installers.

You can keep it like this for stable versions/installers, but it is clear that Enki is not that separate from Qutepart during the development.

When you depend on some fix or new feature in "markdown" or "PyQt4", you update dependency version requirement in README. But it is not feasible to do for "Qutepart" because of during the development Enki's Qutepart minimum version gets updated too frequently.

So that it is feasible to update Qutepart minimum version in Enki's README only when doing a release version and track Qutepart-Enki bond using submodules during the development.

andreikop commented 11 years ago

I have nothing against submodules, I just don't see necessity in this case. I always update Qutepart and install to the system - and things work fine. Please explain, why submodule is necessary