andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

Wait for signal #154

Closed bjones1 closed 10 years ago

bjones1 commented 10 years ago

These commits introduce the waitForSignal function, which I'm using to test my sync code. I also did a bit of rewrite on existing test_preview.py code to use this function, plus fixed a bug in base.py.

andreikop commented 10 years ago

Wow! Cool solution

2 minor issues about coding conventions:

bjones1 commented 10 years ago

Andrei,

Thanks. I've made all the updates -- does that look good?

Bryan

On Fri, Jan 24, 2014 at 1:13 AM, Andrei Kopats notifications@github.comwrote:

Wow! Cool solution

2 minor issues about coding conventions:

  • Could you please use camelCase instead of underscore_separated names. I found a lot of my own underscoreseparated names and fixed it. Rebase to current master. Such names could be found with [a-z][a-z]case sensitive reg exp. I'll think what to do with test case names. unittest forces to use test_ at start of method names.
  • Could you please use docstringshttp://www.python.org/dev/peps/pep-0257/instead of literate-style comments. I'd like to keep Enki coding style uniform.

— Reply to this email directly or view it on GitHubhttps://github.com/hlamer/enki/pull/154#issuecomment-33202043 .

Bryan A. Jones, Ph.D. Associate Professor Department of Electrical and Computer Engineering 231 Simrall / PO Box 9571 Mississippi State University Mississippi state, MS 39762 http://www.ece.msstate.edu/~bjones bjones AT ece DOT msstate DOT edu voice 662-325-3149 fax 662-325-2298

Our Master, Jesus Christ, is on his way. He'll show up right on time, his arrival guaranteed by the Blessed and Undisputed Ruler, High King, High God.

andreikop commented 10 years ago

Thanks!