search

andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

External links in preview dock should open in a browser #170

Closed bjones1 closed 10 years ago

bjones1 commented 10 years ago

IMHO, a click on an external link (one not on the user's PC) should be opened in the default browser, not in the QWebView. It's somewhat confusing to click on a link, then have what's displayed inconsistent with the text (a Markdown file, for example).

By external link, I mean the behavior at http://qt-project.org/doc/qt-4.8/qtextbrowser.html#openExternalLinks-prop: "Links are considered external if their scheme is neither file or qrc."

Perhaps something like http://stackoverflow.com/questions/741984/open-external-browser-from-qwebview?

andreikop commented 10 years ago

Thanks, Done!

bjones1 commented 10 years ago

Wow, works great!