Select filename in rename dialog (getChildren approach)

[vi]

Without the thread hack Qt resets selection after us.

If the code fails, expected behaviour is just all text selected without any error messages, like before.

[andreikop]

Hi

Works fine!

Implementation notes:

• Use findChildren(QLineEdit) instead of find all than check with if
• Use QTimer.singleShot(0, callback) instead of threads. It will fire just after exec_()
• fixupSelection and selectFilenameInInputDialog are used only once. Remove it. IMHO code is more readable, if such blocks are marked with comment

    # select file name in input dialog
   bla()
   foo()
   # fix up selection
   bar()

• cover with tests. You may add some asserts if selection is correct to existing tests in tests/test_plugins/test_workspace_actions.Rename and add new test for file name without extension (like .gitignore ) https://github.com/hlamer/enki/wiki/Hacking-guide#tests

[vi]

I've seen this notes. Maybe implement them once I get "Enki hacking mood" again...

My current implementation is kept afloat by git pull --rebase from update to update. I usually try to force my changes into upstream (i.e. fix these issues and re-submit the pull request) when sick and tired to rebasing them every time.

[andreikop]

Closing to make the list of opened issues shorter. Reopen when having "hacking mood"!