andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 39 forks source link

Add: Quick way to set the Sphinx path based on the current project directory #345

Closed bjones1 closed 8 years ago

bjones1 commented 8 years ago

I put this in the tools menu -- does this seem reasonable?

andreikop commented 8 years ago

Hmm. I generally dislike our way of setting sphinx project path in the global application settings. (However don't have an idea how to do it better.)

The majority of uses doesn't use Sphinx. So, lets show this action only when sphinx project is enabled.

andreikop commented 8 years ago

Just an idea. Now we have a project. Can we try to find conf.py among project files automatically?

bjones1 commented 8 years ago

That makes sense -- I'll enable this only if Sphinx is enabled. I'm not sure what to do when conf.py is found. Note that the directory where conf.py lives doesn't have to be the same as the Sphinx source directory per http://sphinx-doc.org/glossary.html#term-configuration-directory.

andreikop commented 8 years ago

Move the action initialization from _createDock() to the plugin constructor. Now I can't set the path until some preview-able file is opened.

bjones1 commented 8 years ago

Good point. Will do!

bjones1 commented 8 years ago

Thanks for finding this bug! Fixed.

andreikop commented 8 years ago

Merged to master with additional fix. Bryan, could you document Sphinx functionality (including this action) in the user manual? Now there are a small page and a broken link to CodeChat tutorial

bjones1 commented 8 years ago

Thanks! I'll add some docs and a fixed link.

bjones1 commented 8 years ago

Docs added. Does this cover it?

andreikop commented 8 years ago

Yes, now it better!

2 more optional suggestions:

bjones1 commented 8 years ago

Good ideas. Done!

andreikop commented 8 years ago

Thanks! I replaced Sphinx screenshot with Enki documentation index page. It contains table of contents, navigation bar. So, it is more clear what is difference of .rst preview and true Sphinx. I hope you don't mind?

bjones1 commented 8 years ago

Looks good to me!