Preview is synced even if not visible

andreikop / enki

A text editor for programmers

http://enki-editor.org

GNU General Public License v2.0

161 stars 39 forks source link

Preview is synced even if not visible #352

Closed andreikop closed 8 years ago

andreikop commented 8 years ago

While debugging #351 I found that syncTextToPreview() is called and does its job even if Preview is not available for this type of file.

Steps to reproduce:

Open some file which has preview. i.e. README.md
Switch to file which doesn't have preview. i.e. Makefile

Bryan, could you check this?

Is it possible to split preview_sync.py onto 2 simler classes: TextToPreviewSync and PreviewToTextSync? Just an idea, I'm not sure if it is possible and if it makes sense.

bjones1 commented 8 years ago

Oops. I see it.

bjones1 commented 8 years ago

OK, fixed. Thanks for finding this.

In terms of splitting preview_sync.py, that should work. However, I plan on adding features at some point, and will postpone it until then.

andreikop commented 8 years ago

Push this to my v15.11.0. And it seems it time to release the version

bjones1 commented 8 years ago

OK, done. I agree! Lots of improvements and great new features.

andreikop commented 8 years ago

Thank you!