search

andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 39 forks source link

v15.11.1: Preview is not visible #386

Closed vi closed 8 years ago

vi commented 8 years ago 
Traceback (most recent call last):
  File "/mnt/src/git/enki/bin/../enki/plugins/preview/preview.py", line 398, in run
    self.htmlReady.emit(task.filePath, html, errString, url)
UnboundLocalError: local variable 'html' referenced before assignment
vi commented 8 years ago

Is not reproducible in master.

andreikop commented 8 years ago

But the bug still exists. @bjones1, will you have time to check it? exepthook in main.py shows an exception as a messagebox.

bjones1 commented 8 years ago

I'm confused. If the bug can't be reproduced in master, my assumption is that it was fixed by the additional commits. Is there a case where this happens in master?

vi commented 8 years ago

If really needed I can try bisecting.

andreikop commented 8 years ago

@bjones1, I haven't seen the bug but I see that after this the traceback will happen because html is not defined.

bjones1 commented 8 years ago

Good point. I'll move the emit inside the try/catch. Eventually, I would like to send the exception back to the main thread.

andreikop commented 8 years ago

@bjones1, will you have time for this issue in the near future? I'm near to release Py3-Qt5 based Enki

bjones1 commented 8 years ago

I think so. There are a couple of other nitpicks to fix, I'll also file issues as soon as I can.

bjones1 commented 8 years ago

Finally, I just pushed an update which addresses this, plus provides some cleanup of the preview plugin.