andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

Packaging for extensions seems broken #443

Open bjones1 opened 6 years ago

bjones1 commented 6 years ago

@rockiger, I haven't really looked into this yet, but here's what I see when installing Enki from setup.py using the master branch.

qt.svg: Cannot open file 'E:/tmp/venv/lib/site-packages/enki/plugins/pluginmanager/plugins.svg', because: The system cannot find the file specified.
qt.svg: Cannot open file 'E:/tmp/venv/lib/site-packages/enki/plugins/pluginmanager/plugins.svg', because: The system cannot find the file specified.
qt.svg: Cannot open file 'E:/tmp/venv/lib/site-packages/enki/plugins/pluginmanager/document-new.svg', because: The system cannot find the file specified.
qt.svg: Cannot open file 'E:/tmp/venv/lib/site-packages/enki/plugins/pluginmanager/document-new.svg', because: The system cannot find the file specified.
QWindowsNativeFileDialogBase::onSelectionChange () 0
rockiger commented 6 years ago

Seems odd to me. Are the files present?

bjones1 commented 6 years ago

Not there!

E:\Runestone\web2py\applications\runestone\books\pic24_asm_to_c>dir \tmp\venv\Lib\site-packages\enki\plugins\pluginmanager
 Volume in drive E is DATA
 Volume Serial Number is D8B7-ACFA

 Directory of E:\tmp\venv\Lib\site-packages\enki\plugins\pluginmanager

02/19/2018  10:25 AM    <DIR>          .
02/19/2018  10:25 AM    <DIR>          ..
02/19/2018  10:24 AM               801 constants.py
02/19/2018  10:24 AM             7,122 helper.py
02/19/2018  10:24 AM             8,930 installpage.py
02/19/2018  10:24 AM             6,584 pluginspage.py
02/19/2018  10:24 AM               727 todo.md
02/19/2018  10:24 AM             4,113 __init__.py
02/19/2018  10:25 AM    <DIR>          __pycache__
               6 File(s)         28,277 bytes
               3 Dir(s)  401,690,812,416 bytes free

Steps to reproduce (on Windows -- python runs Python 3 on my PC):

python -m venv venv
venv\scripts\activate
python -m pip install https://github.com/bjones1/enki/archive/master.zip
rockiger commented 6 years ago

Hm, I didn't change anything related to the packaging and the files are present. How can that be? Please understand next to nothing about packaging.

bjones1 commented 6 years ago

@rockiger, I understand. Packaging is a deep, dark hole and one area that Python is weak in. Taking a wild guess, perhaps adding package_data['enki'].append('plugins/%s/*.svg' % name) to setup.py around line 105 would fix it.