andreikop / enki

A text editor for programmers

http://enki-editor.org

GNU General Public License v2.0

161 stars 38 forks source link

Add Qt5 Webkit as a weak dependency on Fedora #446

Open abitrolly opened 5 years ago

abitrolly commented 5 years ago

Would be nice to have editor working out of the box with all features.

andreikop commented 5 years ago

It is controversial topic. Some people prefer "batteries included", and some complain "Why do I have to download and install xxx MB of packages just to edit a little file. I would agree with you and install webkit out of the box. @rapgro, what do you think about it?

abitrolly commented 5 years ago

xxx MB?

# dnf remove python3-qt5-webkit
Dependencies resolved.
======================================================================================
 Package                    Arch           Version              Repository       Size
======================================================================================
Removing:
 python3-qt5-webkit         x86_64         5.10-3.fc28          @fedora         571 k

Transaction Summary
======================================================================================
Remove  1 Package

Freed space: 571 k
Is this ok [y/N]:

rapgro commented 5 years ago

Qt5 Webkit is not recommended. https://src.fedoraproject.org/rpms/enki/blob/master/f/enki.spec#_49

bjones1 commented 5 years ago

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

andreikop commented 5 years ago

Just installed python-qt5.qtwebengine on Linux Mint 19. It is +135 MB. (bindings + binaries + dependencies for binaries). Let's make it recommended dependency which is installed by default.

abitrolly commented 5 years ago

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

This issue was forgotten to be closed https://github.com/andreikop/enki/issues/410 then? I am running 17.03.0 - https://apps.fedoraproject.org/packages/enki

bjones1 commented 5 years ago

I just closed #410 -- thanks for pointing that out. It looks like there's not a release with the new non-QWebKit code it in. Perhaps @andreikop can produce one soon. However, code from git master doesn't use webkit.

rapgro commented 4 years ago

Fixed with 19.10.0, no?

andreikop commented 4 years ago

Yes, If you updated Enki to 19.10.0 the issue is fixed.

abitrolly commented 4 years ago

I didn't check, but I trust you. )

andreikop commented 4 years ago

Hey, @rapgro haven't updated Enki yet (probably). I hope he'll close the issue when updated.

rapgro commented 4 years ago

Sorry for the delay. I'm maintaining the Fedora package in my spare time, so I've to ask you to wait. Co-maintainers are of course welcome. See also #465 .

andreikop commented 4 years ago

nop, I just keep the issues open and assigned to have clear status and avoid re-opening and re-discussing the topic.

rapgro commented 4 years ago

464 is a blocker for a new package in Fedora.