search

andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

test_base.TestWaitForSignal fails in Fedora 29 #456

Closed rapgro closed 5 years ago

rapgro commented 5 years ago

Fedora 29: For all of the test_X calls with X in between of 1 to 10:

ERROR: test_X (test_base.TestWaitForSignal)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/enki-18.08.0/tests/test_base.py", line 114, in test_9
    ts.testSignalArgs, 100, (2,)))
  File "/builddir/build/BUILD/enki-18.08.0/tests/base.py", line 464, in waitForSignal
    sip.delete(timer)
TypeError: delete() argument 1 must be sip.simplewrapper, not QTimer

Please let me know if any other information required to reproduce. This issue seems similiar to https://github.com/andreikop/enki/commit/0404b84f19d7cc96a886615cd3f73cf48998ef88

andreikop commented 5 years ago

Do not need to run tests when building packages.

The tests fail often and unpredictable when executed automatically on build machines and even on developers machine with real X server. It is problems of Qt/PyQt but not of the code. I got tired fixing this infrastructure fails and now use tests only for manual testing during development.

I would be happy to have automated tests on build system but it costs Much more time than saves.

rapgro commented 5 years ago

Thanks for your feedback. I use ugly hackery in my spec file to disable those failing tests.