enki tests explicitly try to load non-namespaced sip module

andreikop / enki

A text editor for programmers

http://enki-editor.org

GNU General Public License v2.0

161 stars 38 forks source link

enki tests explicitly try to load non-namespaced sip module #464

Closed rdieter closed 4 years ago

rdieter commented 4 years ago

Recent upstream sip releases generally only support namespaced sip modules, which is what fedora (sip/PyQt5) packaging is now trying to implement, and drop support for non-namespaced sip module.

In investigations removing this support, one problematic case was enki that includes code in tests currently like:

tests/test_lib/test_future.py:import sip tests/test_lib/test_future.py: sip.delete(o) tests/base.py:import sip tests/base.py: sip.delete(timer) tests/base.py: sip.delete(qe)

Possible fixes include:

replacing 'sip' with 'PyQt5.sip' or
remove explicit references to sip altogether

See also downstream issue, https://bugzilla.redhat.com/show_bug.cgi?id=1752766

rdieter commented 4 years ago

and upstream reference to the change, https://www.riverbankcomputing.com/static/Docs/PyQt5/incompatibilities.html#importing-the-sip-module

andreikop commented 4 years ago

I do not support the tests now, because there are a lot of hard-to-track infrastructure problems and the tests consume much more time than save.

rapgro commented 4 years ago

As tests/base.py is considered, I can't build a new package in Fedora without disabling execution of nearly all tests.

andreikop commented 4 years ago

@rapgro, just disable the tests. They are not supposed to be run automatically now. I haven't deleted the tests because sometimes run it manually, but supporting infrastructure for automatic run takes more time than saves because there are many unexpected problems on various platforms.

rapgro commented 4 years ago

Please, don't drop the tests. If they've any sense you should keep with them. That's how TDD should work. Maybe we can drop some difficult platforms then and instead?