andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

Labelless button in message about mixed line endings #48

Closed vi closed 12 years ago

vi commented 12 years ago

"/path/something.o contains mix of End Of Line symbols. It will be saved with '\n'" and a button without any label.

andreikop commented 12 years ago

Do you think you need some text here? Message closes automatically, you don't have to close it, therefore, it is not necessary to have Alt+something shortcut.

But, I agree, OK button without text looks strange. I've changed button icon from "OK" to "Close"

Thanks!

vi commented 12 years ago

The button is still empty (no icons, no labels), at least in my system.

screenshot

andreikop commented 12 years ago

Should have icon. Which distribution, which qt version? 09.09.2012 17:33 пользователь "Vitaly Shukela" notifications@github.com написал:

The button is still empty (no icons, no labels), at least in my system.

[image: screenshot]https://a248.e.akamai.net/camo.github.com/5f0a836d3a0ff0623df0a98fcb4f7d8168131d54/687474703a2f2f76692d7365727665722e6f72672f76692f642f5f2f656e6b695f6661696c2e706e67

— Reply to this email directly or view it on GitHubhttps://github.com/hlamer/enki/issues/48#issuecomment-8404141.

vi commented 12 years ago
$ qmake-qt4 --version
QMake version 2.01a
Using Qt version 4.8.2 in /usr/lib/i386-linux-gnu

Debian unstable.

You can create special branch with additional debugging output of showing the icon so I'll check it.

andreikop commented 12 years ago

Ah, probably gconftool --get /desktop/gnome/interface/buttons_have_icons is false on your system. I forced This button to always have an icon.

vi commented 12 years ago

Now the icon works.

The gconftool --get /desktop/gnome/interface/buttons_have_icons actually returns false.

Why a PyQT program depends on Gnome settings BTW?