andreikop / enki

A text editor for programmers
http://enki-editor.org
GNU General Public License v2.0
161 stars 38 forks source link

Settings: "integer input" widget improvement #73

Closed pvanek closed 11 years ago

pvanek commented 11 years ago

The "integer input" widget has implementation:

label: [horizontal slider] [lcd number]

example: Settings/Editor/Indentation: Width: ----4--------------------- [ 4]

I think, and remember that it can be only mine opinion, that it's quite misleading implementation. Why?

  1. it's imprecise with mouse handling (mainly with more values available - Editor/Edge/ Column number = 0-160)
  2. changing its value is slow
  3. changing its value is almost impossible with keyboard
  4. it takes too much useless space
  5. it displays redundant info (two times "4" in the example above)

I suggest to change it to standard implementation with pair of QLabel/QSpinBox:

label: [spinbox]
andreikop commented 11 years ago

Done. Edge config uses QSpinBox

Indentation width config uses slider + LCD, max value is 16. I think it is quite simple to set precise value with mouse.

pvanek commented 11 years ago

thanks. I still can argue with "precise mouse positioning" mainly because mouse can be: trackpoint, trackball, touchpad, etc. where you usually need to simulate click and move. But I can live with it ;)