search

andreikop / qutepart

Code editor component for PyQt5
http://enki-editor.org
GNU Lesser General Public License v2.1
111 stars 30 forks source link

Python files use Windows line endings (\r\n), not just \n #77

Closed sscherfke closed 5 years ago

sscherfke commented 5 years ago

The python files in the released tarball have Windows line endings (\r\n) and not unix line endings (\n). This is very surprising as most packages use the latter.

Is this intentional? For me, it looks like the git repo uses Unix line endings (but maybe the Git client automatically converts line endings on Linux?).

Anyway, using Windows line endings leads to problems with some tools, e.g., when applying patches that contain Unix line endings (which is the default that most tools use).

andreikop commented 5 years ago

Which download link you use and which file has \r\n. I downloaded zip and tar.gz using Releases page and checked Makefile and qutepart/init.py. It seems like they have \n. But I will not be surprised if github, archive manager or some other software converts EOLs.

sscherfke commented 5 years ago

I downloaded this file from PyPI: https://files.pythonhosted.org/packages/d3/8d/02ae2e73bab6325ab095620c658021bd967ca0756d86490544d85a848b1a/qutepart-3.2.0.tar.gz

andreikop commented 5 years ago

Fixed. But I don't have any idea how I initially managed to create a package with Windows EOLs