search

andreimesinger / 21cmFAST

27 stars 34 forks source link

PS_ION_EFF != ION_EFF_FACTOR #10

Closed qyx268 closed 5 years ago

qyx268 commented 6 years ago

in the new version (with parameters given in the current master branch), it seems that PS_ION_EFF(which is 29.4522 at zp=27.1425; 31.2835 at zp=26.5907; ...; 23.8883 at zp=24.9993; and eventually fluatuates around 25 at zp<22) in double tauX(double nu, double x_e, double zp, double zpp, double HI_filling_factor_zp); is not always the same as ION_EFF_FACTOR (which is 25). Please check if it makes sense.

Note that both fcoll in Ts.c and tauXis calculated through Nion_ST_z at zp, hence I expect PS_ION_EFF is the same as ION_EFF_FACTOR.

qyx268 commented 5 years ago

rounding error when pass the filling factor