Document and cleanup WebSocket implementation

andreiolaru-ro / FLASH-MAS

The Fast Lightweight Agent Shell MAS framework. Easy for beginners, powerful to experts.

GNU General Public License v3.0

5 stars 3 forks source link

Document and cleanup WebSocket implementation #18

Open andreiolaru-ro opened 2 years ago

andreiolaru-ro commented 2 years ago

[x] name of the protocol is Websocket
[x] WebSocketClientProxy is not needed and should be eliminated
[ ] extensive test with all examples

andreiolaru-ro commented 1 year ago

[ ] Check the use of useThread. It would appear that the thread and the message queue are not actually ever used - message received bypass the queue and go directly to their receivers.
- it is questionable, actually, it the thread is necessary, since there is probably something similar in the WSClient actually.

andreiolaru-ro commented 3 months ago

The thread is useful in the case of intensive communication within the same pylon, as the sender and the receiver cannot stay in the same thread (may lead to deadlocks and performance issues as execution for the sender is blocked while the receiver processes the message.

andreiolaru-ro commented 3 months ago

I don't think it is useful to have a separate map of not to websocket in WebSocketServer, node could be registered as normal entities.