Swift 4 migration - Githubissues

andreipitis / ASPVideoPlayer

A simple video player that allow animations to be performed on the view during playback.

MIT License

89 stars 43 forks source link

Swift 4 migration #14

Closed r-dent closed 6 years ago

r-dent commented 7 years ago

I updated Project settings and some parts of the code to work with Swift 4.

The property videoGravity is now of type AVLayerVideoGravity.
The protocol NumericType no longer requires a % method, as this raised compilation problems and was nowhere used anyway.
SWIFT_VERSION is set to 4.0 in project settings.
SWIFT_SWIFT3_OBJC_INFERENCE is enabled as this was a recommended setting during conversion.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.