search

andreipitis / ASPVideoPlayer

A simple video player that allow animations to be performed on the view during playback.
MIT License
89 stars 43 forks source link

Update for Swift 3.1 / Xcode 8.3 #8

Closed iwasrobbed closed 7 years ago

iwasrobbed commented 7 years ago

Great work on this; it's really cleanly abstracted and easy to follow with the closure callbacks.

I updated some areas where you were holding strongly onto self and also removed some warnings in Swift 3.1 / Xcode 8.3.

codecov-io commented 7 years ago

Codecov Report

Merging #8 into master will decrease coverage by 1.01%. The diff coverage is 63.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   84.39%   83.38%   -1.02%     
==========================================
  Files          13       13              
  Lines         923      951      +28     
==========================================
+ Hits          779      793      +14     
- Misses        144      158      +14
Impacted Files Coverage Δ
ASPVideoPlayer/Classes/ASPVideoPlayerView.swift 93.33% <ø> (ø) :arrow_up:
ASPVideoPlayer/Classes/Loader.swift 92% <100%> (ø) :arrow_up:
ASPVideoPlayer/Classes/ASPVideoPlayer.swift 66.92% <18.42%> (-7.43%) :arrow_down:
Example/ASPVideoPlayer/ViewController.swift 78.33% <68.75%> (+0.74%) :arrow_up:
...SPVideoPlayer/Classes/ASPVideoPlayerControls.swift 95.76% <95.74%> (-0.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fd433f...0d47f73. Read the comment docs.

andreipitis commented 7 years ago

Hi, Thanks for the kind words and for the update :).